tqchen commented on code in PR #19942: URL: https://github.com/apache/tvm/pull/19942#discussion_r3523785829
########## python/tvm/testing/locking.py: ########## @@ -0,0 +1,65 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Helpers for tests that use exclusive machine resources.""" + +import os +import tempfile +from collections.abc import Callable +from pathlib import Path +from typing import Any, TypeVar + +from tvm_ffi.utils import FileLock + +_LOCK_DIR_ENV_VAR = "TVM_TEST_LOCK_DIR" +_LOCK_DIR_NAME = "tvm-testing-locks" Review Comment: Thanks for flagging the permission failure mode. I did not add a username suffix because two users sharing one physical GPU would then lock different files and enter the critical section concurrently. The default path is intentionally a same-user coordination domain. A multi-user runner must point every contender at one administrator-provisioned TVM_TEST_LOCK_DIR with a shared-writable persistent lock file, or provide GPU exclusivity in the runner. Commit 66422f7256 documents that contract explicitly and also aligns the example callback name with run_and_check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
