tqchen commented on code in PR #19947:
URL: https://github.com/apache/tvm/pull/19947#discussion_r3524200599
##########
tests/scripts/task_python_unittest.sh:
##########
@@ -62,7 +61,13 @@ TEST_FILES=(
PYTEST_TARGETS=()
for TEST_FILE in "${TEST_FILES[@]}"; do
- PYTEST_TARGETS+=("tests/python/${TEST_FILE}")
+ TEST_PATH="tests/python/${TEST_FILE}"
+ if [ ! -d "${TEST_PATH}" ]; then
+ echo "Missing pytest target: ${TEST_PATH}" >&2
+ exit 1
+ fi
+ PYTEST_TARGETS+=("${TEST_PATH}")
Review Comment:
Applied in f72e7f2389. This array is a list of pytest targets rather than a
directory-only interface, so `-e` preserves the missing-target preflight while
allowing a future individual test file. I validated all current targets, a
representative file target, missing-target rejection, shell syntax, generated
Jenkins equality, the 57 CI-script tests, and changed-file pre-commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
