tqchen commented on code in PR #19955:
URL: https://github.com/apache/tvm/pull/19955#discussion_r3525629657
##########
tests/python/s_tir/transform/test_s_tir_transform_plan_update_buffer_allocation_location.py:
##########
@@ -385,11 +385,11 @@ def test_dltensor_buffer_is_unlowered():
def before(dlpack_handle: T.handle, axis: T.int64) -> T.int64:
ndim: T.int32 = T.tvm_struct_get(dlpack_handle, 0, 5, "int32")
stride_ptr: T.let[T.handle("int64")] = T.tvm_struct_get(
- dlpack_handle, 0, 4, tvm.ir.PointerType(tvm.ir.PrimType("int64"))
+ dlpack_handle, 0, 4, dtype=T.handle("int64").ty
Review Comment:
why is it dtype=T.handle("int64").ty? can we directly pass in dtype="int64"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
