viiccwen commented on PR #19979: URL: https://github.com/apache/tvm/pull/19979#issuecomment-4942596706
> Thanks for fixing! But could you avoid casting the float32 parameters down to the data dtype, as this can lose precision and change the result. > > Since Relax batch_norm requires matching dtypes, please promote all five inputs to a common computation dtype (float32 for this case), run batch_norm, and cast Y back to the original data dtype. > > The test can verify that the batch_norm inputs are float32 while the final output remains float16 I think Thx for pointing out! I'll fix it later. : D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
