tqchen commented on code in PR #670:
URL: https://github.com/apache/tvm-ffi/pull/670#discussion_r3590982020
##########
include/tvm/ffi/object.h:
##########
@@ -531,12 +528,19 @@ class ObjectPtr {
namespace details {
+template <typename T, typename = void>
+struct IsObjectSubclass : std::false_type {};
+
+template <typename T>
+struct IsObjectSubclass<T, std::void_t<decltype(sizeof(T))>>
Review Comment:
seems not needed anymore now that we generate object with subclassing
relationship
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
