tqchen opened a new pull request, #20011: URL: https://github.com/apache/tvm/pull/20011
Cleanup pass over recently merged changes, relying on IR invariants instead of re-checking already-guaranteed conditions. No new features; this is a consolidation/cleanup pass only. ## Changes - **#19940 docsifier (`python_doc_printer.cc`)**: the `ExprStringDoc` escape scope always wraps the printer's fixed in-memory `ostringstream` sink, which never short-writes and never enters a fail state. Drop the streambuf-general short-write reporting in `xsputn`, the ctor `good()` ICHECK, the dtor `rdstate`/`setstate` dance, and the redundant post-render `good()` ICHECK; keep the one-line `saw_newline()` contract. - **#19910 diagnostics (`well_formed.cc`, `block_builder.cc`)**: refresh two "is nullptr" diagnostics to "is missing" now that `Type` is non-nullable and the guards test `ty.IsMissing()`. - **#20005 numeric-gradient tests**: derive the device from the build target via `tvm.device_from_target` inside the helpers instead of threading a redundant `dev` argument that duplicates `target` at every call site. - **target/printer tests**: drop assertions that re-check conditions a preceding assertion already guarantees (isinstance/export-alias/`None`-default re-calls, printer self-determinism re-render). ## Verification All touched Python files pass compilation locally. The C++ changes could not be built in the development environment, so CI is the verification authority for the docsifier and diagnostics changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
