tqchen commented on code in PR #671:
URL: https://github.com/apache/tvm-ffi/pull/671#discussion_r3592753293
##########
python/tvm_ffi/cython/device.pxi:
##########
@@ -115,13 +115,8 @@ cdef class Device:
}
_DEVICE_NAME_TO_TYPE = {
- "llvm": DLDeviceType.kDLCPU,
"cpu": DLDeviceType.kDLCPU,
- "c": DLDeviceType.kDLCPU,
- "test": DLDeviceType.kDLCPU,
"cuda": DLDeviceType.kDLCUDA,
- "nvptx": DLDeviceType.kDLCUDA,
- "cl": DLDeviceType.kDLOpenCL,
"opencl": DLDeviceType.kDLOpenCL,
"vulkan": DLDeviceType.kDLVulkan,
"metal": DLDeviceType.kDLMetal,
Review Comment:
Follow-up: we decided to treat `mps` and `wgpu` as standard device
spellings. Commit 064908b restores them in the C++ parser and adds the matching
Python constructor mappings, so direct construction and typed FFI conversion
remain consistent. The compiler/target aliases (`llvm`, `c`, `test`, `nvptx`,
and `cl`) remain rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
