gemini-code-assist[bot] commented on code in PR #20020:
URL: https://github.com/apache/tvm/pull/20020#discussion_r3598168166
##########
web/package-lock.json:
##########
@@ -1226,14 +1226,14 @@
}
},
"node_modules/@napi-rs/wasm-runtime": {
- "version": "1.1.4",
- "resolved":
"https://registry.npmjs.org/@napi-rs/wasm-runtime/-/wasm-runtime-1.1.4.tgz";,
- "integrity":
"sha512-3NQNNgA1YSlJb/kMH1ildASP9HW7/7kYnRI2szWJaofaS1hWmbGI4H+d3+22aGzXXN9IJ+n+GiFVcGipJP18ow==",
+ "version": "1.1.6",
+ "resolved":
"https://registry.npmjs.org/@napi-rs/wasm-runtime/-/wasm-runtime-1.1.6.tgz";,
+ "integrity":
"sha512-ZLv/JdUfkvOy9eCnnBaGfiO+XimbjebAeO+MRQqD/B+FR1tnRN0tpKSJHRbE8sFfS6aqsXZ67TQjfwfsxULVbg==",
"dev": true,
"license": "MIT",
"optional": true,
"dependencies": {
- "@tybys/wasm-util": "^0.10.1"
+ "@tybys/wasm-util": "^0.10.3"
},
Review Comment:
This pull request includes a large number of dependency updates in
`package-lock.json` alongside the main bug fix. While keeping dependencies
up-to-date is a good practice, it's generally recommended to separate
dependency updates from functional changes into different pull requests.
This approach offers several benefits:
* **Easier Reviews**: It keeps the PR focused on a single concern, making
it easier and faster to review.
* **Simplified Bisection**: If a bug is introduced, it's easier to
pinpoint whether it was caused by the code change or a dependency update.
* **Clearer History**: The git history becomes more readable and
understandable.
Please consider reverting the changes to `package-lock.json` in this PR and
creating a separate one for the dependency updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
