tqchen opened a new pull request, #701: URL: https://github.com/apache/tvm-ffi/pull/701
This restores the established pointer-sized ABI for object optionals while preserving the Any-backed representation for non-object values. Summary: - specialize Optional<ObjectRef>, Optional<ObjectPtr<T>>, and Optional<Arc<T>> on nullable ObjectPtr storage - preserve Any conversions and nested Optional behavior - restore Module APIs to Optional<Function> - restrict Rust Optional<T> to non-object values and document Option<X> for object classes - add C++ and Rust ABI/regression coverage Validation: - full C++ ASAN suite: 465/465 - full Rust workspace: 171 tests and 4 doctests - focused scheduler recheck: 21 C++ tests and 13 Rust optional tests - cargo fmt, clang-format, and diff checks passed Task: https://github.com/tqchen/tdev/issues/313 Staging review: https://github.com/tqchen/tvm-ffi-dev/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
