adityasingh2400 commented on PR #20092: URL: https://github.com/apache/tvm/pull/20092#issuecomment-5198481004
Following up on my last comment, CI has confirmed the fix and all five checks are green: `arm`, `cpu`, `docker`, `gpu`, `wasm`. I said there that I had no TVM build in my environment, could not run the test locally, and was relying on CI for that. The cpu run has now finished: ``` = 10971 passed, 616 skipped, 57 xfailed, 6 xpassed, 630 warnings in 1631.00s = ``` against the previous run's `1 failed, 10970 passed`, so `test_shape_unknown_rank_input` passes and nothing else moved. Reading the type through `params[0].ty` was the right call, and the frontend change from dd1477d was never involved. @tlopex this is still marked as changes requested from your review, and I believe both points are now covered. dd1477d fixed the collapse you identified, where `get_info` mapped both an absent shape and an empty shape to `[]`, and 829262a fixed my own test that was asserting through an API this base does not have. Whenever you have a moment, could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
