tlopex commented on PR #20163: URL: https://github.com/apache/tvm/pull/20163#issuecomment-5389896786
The updated unqualified forward() is ambiguous with std::forward() via ADL for arguments from std, such as arena.make<T>(std::make_unique<int>(7)). This compiles before the PR but fails afterward. Please use std::forward directly (or rename the helper) and add a move-only argument test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
