tlopex commented on PR #20057: URL: https://github.com/apache/tvm/pull/20057#issuecomment-5431007823
Thanks for the update. One issue remains: `_get_spatial_domains_in_access_order` uses `info.dom`, but `_normalize` uses `split_expr.extent` when `lower_factor > 1`. e.g. with spatial shape `(2, 3, 8)` and access `A[n, y, k, x // 2]`, the guard chooses `tx=8`, while the normalized innermost extent is `4`. `bind` still raises `ScheduleError`, aborting the fallback chain. Please base the guard and thread extent on the normalized effective extent and add a regression test for this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
