tqchen commented on code in PR #706:
URL: https://github.com/apache/tvm-ffi/pull/706#discussion_r3903925787
##########
CMakeLists.txt:
##########
@@ -243,25 +243,39 @@ if (TVM_FFI_BUILD_PYTHON_MODULE)
COMPONENTS Interpreter
REQUIRED
)
+ set(_tvm_ffi_python_executable "${Python_EXECUTABLE}")
Review Comment:
seems this is python executable itself, if so avoid setting new item
##########
CMakeLists.txt:
##########
@@ -243,25 +243,39 @@ if (TVM_FFI_BUILD_PYTHON_MODULE)
COMPONENTS Interpreter
REQUIRED
)
+ set(_tvm_ffi_python_executable "${Python_EXECUTABLE}")
+ set(_tvm_ffi_python_version ${Python_VERSION})
Review Comment:
seems this is just python version, if so avoid aliasing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
