The GitHub Actions job "CI" on tvm-ffi.git/optimize-structural-map-engine has 
failed.
Run started by GitHub user tqchen (triggered by tqchen).

Head commit for run:
bad2ef9d6e05e867a49ad18e8d1caaab30fdb89c / tqchen <[email protected]>
[FIX][EXTRA] Guard visit error context on non-object nodes

The structural visit engine names the node it dispatched on in a failed
result's error context. Three call sites annotated that node by casting the
borrowed AnyView straight to ObjectRef, but a visited node is not always
object-backed: a container element or a reflected field may be a primitive,
and AnyView::cast<ObjectRef>() throws on one. The walk is noexcept, so a
callback that failed on a primitive node terminated the process instead of
returning its error.

Add the guarded Error&/AnyView overload alongside the existing guarded
TVMFFIAny one and route the three sites through it, so a non-object node
contributes no context frame. This matches the guard the mutate engine
already applies for the same reason.

Every existing walk error test fails on an ObjectRef node, which is why the
gap was not covered; add a primitive-node regression test over both walk
orders.

Claude-Session: https://claude.ai/code/session_018jQX1azGgoDx3zT6BwsGAk

Report URL: https://github.com/apache/tvm-ffi/actions/runs/33932189094

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to