tqchen commented on PR #783: URL: https://github.com/apache/tvm-ffi/pull/783#issuecomment-5657593234
It is helpful to get BigInt ABI into the tvm-ffi in general and stabilize the ABI. Recording some of the design deliberations: The data representation, there are a few possible choices: including trying a few variants int128 int256, or try go with a single general fallback object. A second decision is whether the data should be normalized, aka can a BigInt large storage represent a number like 0. Currently we converge towards having a single BigInt variant only for numbers that cannot be stored in i64, with a normalization constraint that the storage must be trimmed, and so it helps in things like comparison (e.g. a BigInt container cannot store data within bound of i64). Seems abi wise it something that remain stable without further change, so we inclined on merging this version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
