cchung100m commented on PR #19698: URL: https://github.com/apache/tvm/pull/19698#issuecomment-5675144316
Hi @tlopex Thanks for catching this. You are right that disabling the fast path for every explicit scale was too aggressive. I've updated the fix so the integer-division path is only skipped when the explicit scale actually disagrees with the ratio implied by the sizes; when it agrees (as in your example), it's still used and gives the exact result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
