lucifer1004 commented on PR #814: URL: https://github.com/apache/tvm-ffi/pull/814#issuecomment-5840947558
Thanks @tqchen, agreed on the rationale. Errors should be returned as `Result`, and catching panics is only a safety net so that a stray panic (indexing, `unwrap`, a failed check) raises an error instead of aborting the process. The export macro and `Function::from_packed` / `from_typed` docs now say this, and the tests note that they panic only to exercise the safety net. I updated the title and description to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
