On Wed, Nov 21, 2012 at 11:15:41AM -0500, Tom Rondeau wrote: > [...] > I just pushed a branch to my github repo called iir_filter that > implements the optional argument to the IIR filter as we discussed. > The default is oldstyle=True and doesn't change any behavior. If you > set this to False, you can directly copy taps from programs like > gr_filter_design (the new version not yet integrated into GNU Radio). > > Comments, questions, etc.? If no one sees a problem with this, I'll > merge it into next.
I didn't actually build and test it, but I do like this solution and it seems correct. A very, very minor suggestion is to apply the attached patch, it's probably a bit OCD, but it changes the formulas in the doxygen block to reflect the change, as well. MB -- Karlsruhe Institute of Technology (KIT) Communications Engineering Lab (CEL) Dipl.-Ing. Martin Braun Research Associate Kaiserstraße 12 Building 05.01 76131 Karlsruhe Phone: +49 721 608-43790 Fax: +49 721 608-46071 www.cel.kit.edu KIT -- University of the State of Baden-Württemberg and National Laboratory of the Helmholtz Association
From 8d273730f48aef2ec70d49d6e6ca09c36092ae29 Mon Sep 17 00:00:00 2001
From: Martin Braun <martin.br...@kit.edu>
Date: Thu, 22 Nov 2012 09:32:39 +0100
Subject: [PATCH] filter: Matched doxygen docs to reflect oldstyle change
---
gr-filter/include/filter/iir_filter.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gr-filter/include/filter/iir_filter.h b/gr-filter/include/filter/iir_filter.h
index f2c644a..e7ea52f 100644
--- a/gr-filter/include/filter/iir_filter.h
+++ b/gr-filter/include/filter/iir_filter.h
@@ -56,13 +56,13 @@ namespace gr {
* The input and output satisfy a difference equation of the form
\f[
- y[n] - \sum_{k=1}^{M} a_k y[n-k] = \sum_{k=0}^{N} b_k x[n-k]
+ y[n] \pm \sum_{k=1}^{M} a_k y[n-k] = \sum_{k=0}^{N} b_k x[n-k]
\f]
* with the corresponding rational system function
\f[
- H(z) = \frac{\sum_{k=0}^{N} b_k z^{-k}}{1 - \sum_{k=1}^{M} a_k z^{-k}}
+ H(z) = \frac{\sum_{k=0}^{N} b_k z^{-k}}{1 \pm \sum_{k=1}^{M} a_k z^{-k}}
\f]
*/
iir_filter(const std::vector<tap_type>& fftaps,
--
1.7.9.5
pgpl3ztbRHUnm.pgp
Description: PGP signature
_______________________________________________ Discuss-gnuradio mailing list Discuss-gnuradio@gnu.org https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
