Thanks for reporting this. My commit is indeed responsible for this.
Fixed one bug, but added a new one...
The expression splitting code seems to be very fragile =)

Please check out this branch that contains an updated fix
https://github.com/skoslowski/gnuradio-wg-grc/tree/callback_fix_doover

Let me know if that's working for you.

Sebastian

On 05/16/2016 07:27 PM, Achilleas Anastasopoulos wrote:
> I think I found out what is going wrong with this:
>
> After the above commit, the compiled python files places the 
> "probe" definition blocks AFTER the definiotion of the thread.
>
> See attached pythoon script:
>
> In line 219 we have the definition:
>
> -----------------------------------------------------
> def _freq_acq_est_probe():
>             while True:
>                 val = self.blocks_probe_freq.level()
>                 try:
>                     self.set_freq_acq_est(val)
>                 except AttributeError:
>                     pass
>                 time.sleep(1.0 / (10))
>         _freq_acq_est_thread =
> threading.Thread(target=_freq_acq_est_probe)
>         _freq_acq_est_thread.daemon = True
>         _freq_acq_est_thread.start()
>         self._fmaxt_static_text = forms.static_text(
>                 parent=self.GetWin(),
>                 value=self.fmaxt,
>                 callback=self.set_fmaxt,
>                 label="f_max (Hz)",
>                 converter=forms.float_converter(),
>         )
> ----------------------------------------------
>
> while the probe block is defined only AFTER in line 263
>
> ---------------------------------------
> self.blocks_probe_freq = blocks.probe_signal_f()
> ----------------------------------------
>
>
> The situation is not the same before that commit...
> I suppose this is a bug.
>
> best
> Achilleas
>
>
>
>
>
> On Sun, May 15, 2016 at 11:49 PM, Achilleas Anastasopoulos
> <anas...@umich.edu <mailto:anas...@umich.edu>> wrote:
>
>     Some of my grc apps in gr-cdma using probe blocks in grc are
>     broken after the above commit.
>     Not sure what the problem might be but when apps start they give
>     the following error:
>
>
>     Exception in thread Thread-1:
>     Traceback (most recent call last):
>       File "/usr/lib64/python2.7/threading.py", line 811, in
>     __bootstrap_inner
>         self.run()
>       File "/usr/lib64/python2.7/threading.py", line 764, in run
>         self.__target(*self.__args, **self.__kwargs)
>       File "/home/anastas/Dropbox/gr-cdma/apps/cdma_txrx.py", line
>     221, in _freq_acq_est_probe
>         val = self.blocks_probe_freq.level()
>       File
>     "/usr/local/lib64/python2.7/site-packages/gnuradio/gr/hier_block2.py",
>     line 92, in __getattr__
>         return getattr(self._impl, name)
>     AttributeError: 'top_block_sptr' object has no attribute
>     'blocks_probe_freq'
>
>
>     The commit log says:
>
>     -------------
>     commit c85984f105106ff0a7e3b387d680e0f2f5884d55
>     Author: Sebastian Koslowski <koslow...@kit.edu
>     <mailto:koslow...@kit.edu>>
>     Date:   Wed Apr 27 14:19:04 2016 +0200
>
>         grc: fix callback evaluation
>     --------------
>
>     but I am not a grc expert to understand what went wrong.
>
>     Please let me know if you need more info about the erros.
>
>     thanks
>     Achilleas
>
>
>
>
> _______________________________________________
> Discuss-gnuradio mailing list
> Discuss-gnuradio@gnu.org
> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio


_______________________________________________
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Reply via email to