Right now, the block is unusable with tags because of the tag time drift. I'm ok with the residual jitter caused by enable_update_rate(), just like it is in msk_timing_recovery_cc.
Can we commit this partial fix, and open a new bug to fix tag timing jitter in all these blocks? Blocks using enable_update_rate: clock_recovery_mm_cc_impl.cc clock_recovery_mm_ff_impl.cc msk_timing_recovery_cc Jonathan. On Tue, Aug 9, 2016 at 2:26 PM, Tom Rondeau <[email protected]> wrote: > On Tue, Aug 9, 2016 at 5:51 AM, Jonathan Brucker <[email protected]> > wrote: >> >> Would it be possible to apply this bugfix before the release? >> https://github.com/gnuradio/gnuradio/pull/888 >> >> It's a one-liner: >> enable_update_rate(true); // fixes tag propagation through variable rate >> block >> >> The symptom of the bug is: >> tags pushed into the block appear with a drifting time offset at the >> output, instead of being synchronized. >> >> It affects both: >> clock_recovery_mm_cc_impl.cc and clock_recovery_mm_ff_impl.cc >> >> This fix was already applied to msk_timing_recovery_cc but is missing >> from clock_recovery_XX. >> >> Thanks, >> Jonathan. > > > > The enable_update_rate will help with the drift, but it doesn't fully solve > the problem of the correct tag placement. > > I fixed this in the PFB timing recovery blocks by manually placing the tags > on the correct sample. A similar tactic should work for all of these other > blocks. > > Tom > > > >> >> On Mon, Aug 8, 2016 at 3:36 PM, Nathan West-GR <[email protected]> >> wrote: >> > Hi all, >> > >> > Just giving a heads up that I expect to release GNU Radio v3.7.10.1 (a >> > bug >> > fix release) Wednesday evening (US eastern time). This will primarily be >> > some GRC fixes and a few other miscellaneous things. >> > >> > If you have pending bug fixes you want to get in the release let me know >> > and >> > we can work to make sure your fixes get in. >> > >> > Cheers, >> > Nathan >> > >> > _______________________________________________ >> > Discuss-gnuradio mailing list >> > [email protected] >> > https://lists.gnu.org/mailman/listinfo/discuss-gnuradio >> > >> >> _______________________________________________ >> Discuss-gnuradio mailing list >> [email protected] >> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio > > _______________________________________________ Discuss-gnuradio mailing list [email protected] https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
