You're not doing anything wrong. The comments you received are
incorrect. If you clang-format your files, you'll be fine.
Ron
On 5/10/20 04:08, Christophe Seguinot wrote:
Hi
I recently submitted an "add eye_sink" PR. (as I'm not familiar with
PR, I made several attempts/close : correct coding standard and new
line at EOF....)
I'm sucked on a request to use the following format for short function
<https://github.com/gnuradio/gnuradio/pull/3221#discussion_r382370799>
function()
{
code;
}
However using GNURadio coding standard
<https://github.com/gnuradio/gnuradio/blob/master/.clang-format>
clang-format uses the directive:
AllowShortFunctionsOnASingleLine: All
which format short function on a single line.
What am I doing wrong?
Please could someone guide me to the right direction so that my next
PR will be the good one?
Regards
||
