Hi Eric,
I don't think that this patch is the way to proceed. You implement a few
different ideas in there that will each cost a lot of runtime. It surely
is a great idea to move the determination of the colours into a separate
method, but we should only get the one current colour plus its valid
range from that method and not compute more at once.
And sending each glyph over to the backend separately is definitely
wrong. We just need to make sure that the advancements we compute in the
layout manager match the actual advancements. You change just spreads
out that error over all glyphs, while the current code shows it at the
end of a glyph run that got displayed at once.
Fred
On 31.10.2011 20:46, Eric Wasylishen wrote:
Hi Sebastian,.
I see something similar if I increase the UI scale factor with GSScaleFactor,
except text has gaps in it instead of being bunched together.
I tracked that problem to the method -[NSLayoutManager
drawGlyphsForGlyphRange:atPoint:] which is hard to understand and seems to be
buggy. I started a rewrite of that method a while ago but never finished it.
If you want, you could try applying the attached patch and see if it fixes your
problem.
The patch fixes the spacing problems I observed, but it is incomplete; it may
not properly change styles when drawing an attributed string (and it's also
slow) - so it's not ready to apply.
Eric
On 2011-10-31, at 10:25 AM, Sebastian Reitenbach wrote:
Hi,
don't know when this started, or maybe its a default I've set?
Some texts in applications are looking fairly ugly. Some letters appear fairly
squeezed together. On the console I don't see any warnings regarding fonts.
Also the cursor in GWorkspace Run dialog is blinking in the middle of the last
typed letter, not after it.
See attached screenshot, its not only in gworkspace, all apps seem to have this
problem. I'm using latest svn.
Sebastian<gworkspace.png>_______________________________________________
_______________________________________________
Discuss-gnustep mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/discuss-gnustep
