On 2019-07-08 18:54:10 +0200 Fred Kiefer <[email protected]> wrote: > OK, this is quite reassuring. So the change is basically working as expected. > But with themes that use a colour list where the new value isn’t present we > get the „wrong“ colour. Not exactly. It seems that toolTipColor and toolTipTextColor of NSColor.m aren't available for these themes and that they are both replaced with black.
For instance, if I replace at line 239 of GSToolTip.m [window setBackgroundColor: [NSColor toolTipColor]]; by [window setBackgroundColor: [NSColor redColor]]; then, the tooltips become red with all themes. I looked at GSTheme.m to see if there is some code to load the system colors, where we should add something for toolTipColor, but I didn't find any. >That is the hard coded black colour instead of > the currently selected text colour as you expect. First we need to make > Thematic aware of the new colour keys, no idea how this is done. Next we > should extend the existing themes to support suitable colours for these keys. > But we also should think about a fallback mechanism in gui that is a bit more > clever. We should automatically use the text colour if the tool tips text > colour is not defined. I will try to come up with something like that. These kind of fallback should already exist for the other system colors. Where ? > Any taker for the Thematic and the themes task? I'll try to lok at Thematic code, but don't expect anything great. Bertrand > >> Am 08.07.2019 um 12:52 schrieb Bertrand Dekoninck >> <[email protected]>: > >> On 2019-07-08 08:26:45 +0200 Fred Kiefer <[email protected]> wrote: > > > >>>> Am 07.07.2019 um 23:51 schrieb Bertrand Dekoninck >>>> <[email protected]>: > >>>> On 2019-07-07 22:06:32 +0200 Fred Kiefer <[email protected]> wrote: > >>>>> I have added two additional colours to NSColor: toolTipColor and >>>>> toolTipTextColor. They now get used in the tool tip display code. The >>>>> easiest way to adjust these colours in a theme is by using a colour list >>>>> in the theme where these colours are set to the desired values. > >>>>> Fred > > >>>> I see that you've set toolTipTextColor to black. That should work. >>>> But I've build and installed again gui and see no difference when using >>>> Sombre : tooltips' textcolor is still white on a lightyellow background. >>>> Do I miss something ? >>>> Bertrand > >>> Oops, this sounds wrong, I will need to test this but won’t have time >>> until very late today. Do you know how Sombre redefines the colours? Is it >>> using a colour list or overriding NSColor methods? > > >> Sorry, it was my fault, but the state isn't perfect yet. >> I did install gui's update in the System domain, but it was still present >> in the Local domain, so I did'nt use the update. I've cleaned my system and >> it seems to be partially workong now. >> Any theme that uses default gnustep colors is correct (default, Heritage, >> WinClassic), but all those who have a custom color list are wrong (Nesedah, >> Narcissus, Neos, Rik, Silver, Sleek, Sombre, ThinkDark) : tooltips have >> black text on a black background. >> Bertrand > > >> _______________________________________________ >> Discuss-gnustep mailing list >> [email protected] >> https://lists.gnu.org/mailman/listinfo/discuss-gnustep > _______________________________________________ Discuss-gnustep mailing list [email protected] https://lists.gnu.org/mailman/listinfo/discuss-gnustep
