Hi John,
> All feedback is appreciated!
nice work so far! I clicked it all and tried to find errors or inconsistencies.
I list them below in a kind of stream-of-thoughts. Most problems should be
obvious, please just ask if anything is unclear.
- a @see would be nice to add links to related functions (eg. change ->
onechange, unchange)
- would be nice to reference the selector equivalent in the dom-traversing
methods (eg. for children(String expr) mention "div>expr")
- category for events (bind (eg. change(function)), onebind (eg.
onechange(function)), unbind (unchange(function)), call (eg. change()) )
- category for css properties
- $.each and $.extend are static methods of the jQuery "class", while the other
functions are all methods of the jQuery object, right?
- examples for $.each, $.extend are missing
- mention what happens if $.extend is called with only one parameter
- the examples for the add methods are confusing: $("p") with
<p>Hello</p><p><span id="a">Hello Again</span></p> should result in [
<p>Hello</p>, <p><span id="a">Hello Again</span></p> ], therefore $("p").add(
document.getElementById("a") ) should result in [ <p>Hello</p>, <p><span
id="a">Hello Again</span></p>, <span id="a">Hello Again</span> ]
- html examples could be formated with linebreaks and indent
- append() misses the parameter, a String
- background() example returns nothing, bad example
- bind has more then one example, which does not work yet, the text for the
next example sticks in the result box of the current
- each(function): the example does not include the mentioned index variable
- error(): I didn't know that this event exists, but after reading about it,
the example should be changed to use an image, as the main purpose for onerror
seems to be with images that can't be loaded
- fadeIn() and all those animations: would be groovy to have a animated example
inside the docs, not too hard to be done with jQuery, right?
- filter: What is meant by "basic XPath"? Does jQuery support all XPath 1.0
functions or not? The result repeats the example ($("p").filter(".selected")),
is that necessary?
- get(): the result could use an additional comma in the array notation
- get(Number): the result should not be an array, as it return only the single
element, so remove the brackets
- hover(): A hover(function) would be nice, to call a toggle function; by
adding "out = out || over;"
- load(): Isn't there load(url, function)? Seems like the other AJAX methods
are missing, too. I guess its on purpose...
- ready(): Remove the reference to the event module ("This is probably the most
important function included in the event module"), as the normal jQuery user
dosn't need to know about the "core modules"
- text(): Add a second example where text() is called on more than one element
and/or on an element with child elements
- toggle(function, function): make clear that this toggle binds a click event,
while the other two toggle functions are executed immediatly
I'm looking forward to see the next update. Keep it up!
-- Jörn
--
Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen!
Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer
_______________________________________________
jQuery mailing list
[email protected]
http://jquery.com/discuss/
