Hi, first of all, thanks for the great plugin.

I just wanted to point out a few other things I noticed on top of the back button problem when I was integrating this plugin in my project yesterday. In your rotate example http://www.stilbuero.de/jquery/tabs/rotate.html I noticed a bug in the count. You are using:

var tabs = $('li', '#rotate').size();


When it should be more specific than that as someone could have an un/ordered list inside one of the tabs -- therefor breaking the count.

var tabs = $('.anchors li').size();
is what I used instead.

On a related note in regards to the rotation, it would also be really nice if the "bookmark" ability (awesome by the way) could stop the rotation if a user specifically got to the page by the hash. Obviously this feature would be nice but, by no means, is it really important.

- James

On 9/28/06, Klaus Hartl <[EMAIL PROTECTED]> wrote:


abba bryant schrieb:
> For some reason if I load the page and click some tab the hash changes. If I
> then copy the address from the address bar, and reload the initial page the
> hash stops changing on tab click. The tab content loads fine. Also if I
> bookmark tab 3 and then go to tab 1, then load the page from the bookmark
> the tab doesn't select.
>
> Also, if you load the page and #section-5 ( or whatever the hash might be )
> is added to the url the page doesn't load the tab according to the url. Is
> this correct behavior? I was expecting to be able to bookmark a specific tab
> or load a specific tab from an url hash.


Gosh! I see what you mean. I'd call that the back button problem - if
you use the back button you get the same behaviour.

The problem is, that there's is no load event fired no more while using
the back button or if you just change the hash in the url.

If you'd load another page in between and then use your bookmark it
works as intendend.

Ok, at least I will have to implement the back button :-) Ugh!



-- Klaus

_______________________________________________
jQuery mailing list
[email protected]
http://jquery.com/discuss/



--
- NoCopy
_______________________________________________
jQuery mailing list
[email protected]
http://jquery.com/discuss/

Reply via email to