Hi Jörn,
Jörn Zaefferer wrote:
>
> What I like about it:
> It works on Opera 8.54 & 9.02 and IE7RC1, too.
> Clean and structured code, good examples provided. There were some
> updates to the Plugins/Authoring guide which you may want to include.
>
Thanks for the browser tests. I'm sure Safari will crap out. (will test
tonight at home)
> What I don't like:
> You extracted the playerpath, but not the name of the player object
> itself: Would be nice to have that extracted into the playerpath.
> The code to create the object element is quite clumsy. For performance
> reasons, you should use an array with join(""). For code readability,
> something else is necessary, but I haven't a good solution for this at
> hand.
> It is not unobtrusive: I don't get anything useful without JS, though no
> JS is necessary for the flash object. It's true that the object code is
> quite clumsy, but this should be handled by a plugin or template on the
> server-side. This point makes your plugin pretty useless on sites, that
> don't strictly require JS. In that case, your plugin is nice, because
> you don't have to implement the plugin for every server-side scripting
> language available...
>
Whew! Good thing I said 'be gentle!' LOL
Just kidding. I appreciate the time taken to look over my work. This is my
first attempt at a plugin. I'm primarily a server-side guy. I only did it
out of my sheer excitement for jQuery, and the desire to give a little back.
I think I saw an array join-vs.-concatenate JS performance article before...
I'll probably do that first.
I've removed the unobtrusive "feature" line... Unobtrusive != Doesn't Work
haha. I'm not sure I get what you're saying about the object
element/code... I just did a quickie concatenation, which I knew was not
optimal. I'll read up more on that for my next plugin ;)
Thanks,
________
SEAN O
--
View this message in context:
http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6742878
Sent from the JQuery mailing list archive at Nabble.com.
_______________________________________________
jQuery mailing list
[email protected]
http://jquery.com/discuss/
