>Erin, > >> I like your work. Here are a few suggestions. >> >Thanks. I took your suggestions (bug reports) and made additional changes: >http://foofiles.com/2006/10/14/greybox/test.html >http://foofiles.com/2006/10/14/greybox-rework-2006-10-14.tgz > >> If the link to activate the greybox is near the bottom of the page and the >> page >> had to be scrolled to show the link, the greybox will appear not in the >> middle >> of the visible window but back up near the top. >> >Fixed: The greybox's CSS top is set to the top of the current visible window.
Great work, bug exterminated! Could you have an option for the greybox to appear centered both horizontally and vertically? > >> If the page has scrollbars and the user scrolls the page while the greybox is >> visible the overlay is shown to not cover the entire page. >> >I liberally copied ThickBox2.1's page overlay size (with slight >modification), getPageScrollTop and getPageSize functions to properly >calculate (from what I've tested) the positioning and overlay size. Looks good. >(modified greybox.css, added width: 100% so IE would work). Side note, >greybox redux was originally LGPL'd, whereas thickbox is MIT licensed. >Anyone care to guess how this resolves? > >> A horizontal scroll bar appears in FF. What I meant (although no longer a problem) was that a horizontal scrollbar appeared in the PARENT window if there wasn't one before. > > >A h-scroll bar in the greybox using firefox? If that's what you mean, >it sounds reasonable if the page within the greybox iframe is larger >than the width of the greybox itself. > > > If the page is scrolled with the greybox visible the greybox does not > > recenter itself. > > >Fixed. Caveat: one seems to be able to scroll down indefinitely... >shrinking that vertical scrollbar (as it should). I'm not sure what >would happen if the user scrolled down an insane distance because I >didn't try it. Fixed positioning now works with vertical scrolling but still a problem with horizontal scrolling. Thanks for the bugs fixes. Erin > >Note: Files modified are greybox.css and greybox.js. > >Thanks for the feedback again. I'm not a javascript or DOM programming >expert, so please continue to correct me where I fubar things up. :) > >Again, I tested using jquery-1.0.2.js: >Tested in IE (6.0.2900.2180) >Tested in Firefox (1.5.0.7) >Tested in Safari 2.0.4 (419.3) > >Cheers, >Ben > >_______________________________________________ >jQuery mailing list >[email protected] >http://jquery.com/discuss/ _______________________________________________ jQuery mailing list [email protected] http://jquery.com/discuss/
