Klaus,
Great job on the Tabs plugin.
One suggestion on semantics... I'd consider renaming the fxAutoheight
setting. As it stands now, setting this to be True causes all tab heights
to be constant (the height of the tallest tab). Whereas, set to "false",
the height adjusts *automatically* to the size of the current tab's content.
This can be confusing.
It should also be CamelCase for consistency... "fxTallestHeight" perhaps?
________
SEAN O
Klaus Hartl wrote:
>
> Hi jQuerians,
>
> I worked on the tabs plugin, did some clean up and changed the "API" a
> little bit, so that I call it v2.0 now:
>
> * to pass in the initial tab to start with you no longer specify it with
> an "on" option. Instead you pass the number as first parameter to the
> tabs() function (that's the way it was in the beginning and I found
> passing in the initial tab as {on: 2} a little too verbose):
>
> $(...).tabs(2);
> $(...).tabs(2, {
> // options
> });
>
> No index but options works fine as well:
> $(...).tabs({
> // options
> });
>
>
> * The plugin uses the proposed method to initialize settings:
>
> settings = jQuery.extend({
> ...
> }, settings || {});
>
> * I made the class name for the currently selected tab configurable via
> settings (default is now .selected)
>
> * I removed conditional compilation and replaced it with
> jQuery.browser.msie checks. That means the plugin is now packable.
>
> Therefore the ant build file contains a task 'pack_tabs' that creates a
> packed version in the dist folder...
>
> * Here is an overview of the settings that can be passed in inside the
> object literal (shown values are default values):
>
> {
> fxFade: null,
> fxSlide: null,
> fxShow: null,
> fxHide: null,
> fxSpeed: 'normal',
> fxShowSpeed: null,
> fxHideSpeed: null,
> fxAutoheight: false,
> callback: null,
> selectedTabClass: 'selected',
> hiddenTabContainerClass: 'tabs-hide'
> }
>
> I promise to add some useful inline documentation soon (finally).
>
>
> * I am too still working on the history plugin and if both plugins are
> used together back/forward button will be enabled for the tabs (work in
> progress).
>
>
> Cheers!
>
>
> Klaus
>
>
>
>
>
> _______________________________________________
> jQuery mailing list
> [email protected]
> http://jquery.com/discuss/
>
>
--
View this message in context:
http://www.nabble.com/Tabs-plugin-2.0-tf2481044.html#a6921215
Sent from the JQuery mailing list archive at Nabble.com.
_______________________________________________
jQuery mailing list
[email protected]
http://jquery.com/discuss/
