> It was dying on the if... I removed the check !arg.nodeType for > testing and it worked (commenting out the other stuff) > > We need to look into this more. I bet passing a nodeList with > these text nodes would probably still result in Safari crashing. > The quick-fix is there but I think it might still have issues. > Is the check for !arg.nodeType necessary?
In May there was a bug filed and I suggested that patch. http://jquery.com/discuss/2006-May/004735/ The problem is that there are a few DOM elements with length properties such as forms. (The form.length property is an alias for the form.elements.length collection, which is unfortunate.) You *don't* want to treat DOM elements like collections but instead just push the node itself. The easiest way I could think of to do that was to check for .nodeType indicating it was a DOM element. Perhaps there is some other indicator that won't incur the wrath of Safari? _______________________________________________ jQuery mailing list [email protected] http://jquery.com/discuss/
