On 11/16/06, Brandon Aaron <[EMAIL PROTECTED]> wrote:
> Currently the show and hide methods leave a trail of inline styles
> behind. Should they? I recently fixed bug #276 to remove the
> unecessary inline styles once a show or hide animation is completed.
> This will no doubt break some people's code who are hiding things via
> a stylesheet and expecting the show method to keep it display block. I
> would consider this a bad practice and having inline styles can
> completely break print styles and cause unwanted/unexpected results
> like bug #276.
>
> Opinions? The only time inline styles would be in place is with a hide
> call but a show call would reset the style property back to the
> stylesheet.

I'm thinking the best option for now is to keep the inline style for
display but in the fx module store the original and restore it back at
the end like the regular show and hide methods do (even though it will
be inline). I'm going to move forward with this but still want to know
people's opinions on the inline styles issue. This will not result in
people's code breaking if they relied on the inline style being there
at the end of a show animation. We can possibly pull them out for the
1.1 release.

--
Brandon Aaron

_______________________________________________
jQuery mailing list
[email protected]
http://jquery.com/discuss/

Reply via email to