Hi, > http://www.alterform.com/resources/jqbrowser-2
Very nice. I really like it, but I don't understand why you keep values like e.g. 'safari' in a private object and copy it to the public one. As far as I can see you only set the values in the private object during initialization and never touch them again after you have copied them to the public object. I also can not see the reason why you whant OS, browser, linux, etc. to be functions. As far as I can see they return precalculated values. If is a lot faster to access a value of a variable that it is to call a function which is a value of a variable and only returns a value of another variable. The function version.string() returns a predefined variable in case no parameters are provided. In case there are parameters, the same as version.number(1).toString() is provided. Not only may that be confusing, I also think, that the version with parameter is not necessary. You can change that to a variable as well. The function version.number() also behaves different with or without parameters. Without parameters it also returns a precalculated value. With parameters it returns a value that could be precalculated - the return value never changes over the time. I'd suggest two variables like version.number and version.major for that. Christof _______________________________________________ jQuery mailing list [email protected] http://jquery.com/discuss/
