hi liquid, nice, really nice!

i spend the last 30 minutes to play around with jAssistant and figured out
some issues and another 30 minutes to write this down. hope it supports you
to fix things...

1.) in FF 2.0, browsing your demo site: if i drag the window handle,
sometimes the dialog frame "jumps" with it's header above the browser page.
after that, the window title (drag handle) is in the unreachable part of the
screen and there is no way to close the dialog. this problem is only on your
demo page. the downloaded and locally installed example is ok.
see the screenshot @ http://flicks.homeip.net/_dev/images/jassi_sc.jpg to
get an idea...


2.) you can also drag the handle outside the window - - with the same effect
as above

3.) your download example works fine in FF2 but produces an error in IE7
wich says "variable, string or number expected in line 19" wich is the
higlighted one in the following snipplet!??? - once again FF2 is fine:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "
<http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd>
http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
<html xmlns=" <http://www.w3.org/1999/xhtml> http://www.w3.org/1999/xhtml";>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title> 
<script src="jQuery.js"></script>
<script src="jAssistant.js"></script>
<script>
$(document).ready(function()
{
 $('#showAssistant').click(function()
 { 
  $('#assist').jAssistant(
  {
   tabsNum: 4,
   tabs: {1: {name: "Your Files", content: "content-1"},
          2: {name: "Your Recent Downloads",content:"content-2"},
          3: {name: "Your Comments",content:"<h1>Comments</h1>", type:
"html"},
          4: {name: "Your Settings",content:"1.html", type: "ajax"},
         },
   title: "jAssistant - The jQuery Dialog Box",
   theme: "aero",
   show: "yes", 
   top: 250, 
   left: 400, 
   width: 650, 
   height: 550, 
   resizable: "yes"
  });
  $("#assist").css('visibility', 'visible');
 });
});

4.) the fourth tab (ajax get to 1.html) didn't work at all. firebug just
reports the expected result "<h1>Settings</h1>" as HTTP response, but the
content didn't show up.

5.) when first popup the dialog, the CSS of the containing page is modified.
check the download example, the button first has a top-left margin/padding -
after clicking the button the padding disappears. i think this is because
you inject main2.css wich contains the following global rules:

      body, div, dl, dt, dd, ul, ol, li, h1, h2, h3, h4, h5, h6, 
      pre, form, fieldset, input, p, blockquote, th, td {
        margin:0pt;padding:0pt;
      }

my understanding is, that you have to avoid the usage of global CSS rules
that will be injected into an existing page, because you break every CSS
based layout. work with classes/ids instead (as do do in the most cases)

6.) last thing - i'm really missing a short parameter documentation. for
example what means start: "center"? is the dialog pops up in the center of
the frame/window? btw - I try it, but it didn't "center" at all... 

regards, steff


_______________________________________________
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/

Reply via email to