On Thu, May 17, 2012 at 8:38 AM, Milan Jurik <[email protected]> wrote: > Hi Gordon, > > first of all, I am moving this to discuss@ > > > On 15.05.2012 18:06, Gordon Ross wrote: >> >> In a recent code review discussion, we found ourselves in a discussion >> of the general dislike for changes that touch a lot of places in our code. >> I've been meaning to write something about this for a while, so here >> is my attempt to explain. >> >> [...] > > I am well-aware that I am doing a lot of small and big changes with > minimal impact on the functionality, e.g. with lint 12.3 changes I > touched frequently parts of gate. This fulfill what you are writing about. > And yes, it consumed a lot of time for reviewers. Time which could be > spent by something else, like the next ZFS. > I hope I tried to push for reviews gently. If not then I am sorry. > > So I take your e-mail as something which is against my work here > and I would like to explain my position.
You seem to be assuming that what I wrote was directed specifically at you or your work. I tried to explain my concerns about this topic without singling out anyone in particular. I don't recall too many occasions where your change proposals seemed to have an amount of change that was out of balance with the amount of improvement provided. [...] > I will continue with fixing corner cases and doing clean up of the > code as long as I will find reviewers and advocates taking some > value from it. If members of dev-council and/or advocates will say > "Stop, we are not interested" then I have no other options than > to respect it. Is someone telling you to "stop"? That was not the intention of the piece I wrote. Rather, it was advice to try to keep the amount of change "in balance" with the value provided. Thanks for your efforts. I do hope you will continue. -- Gordon Ross <[email protected]> Nexenta Systems, Inc. www.nexenta.com Enterprise class storage for everyone ------------------------------------------- illumos-discuss Archives: https://www.listbox.com/member/archive/182180/=now RSS Feed: https://www.listbox.com/member/archive/rss/182180/21175430-2e6923be Modify Your Subscription: https://www.listbox.com/member/?member_id=21175430&id_secret=21175430-6a77cda4 Powered by Listbox: http://www.listbox.com
