On 07/02/2012 08:28 PM, Gordon Ross wrote:
This raises some questions for me.
The only client I've heard about for WebNFS is the Sun Java one, now:
http://java.net/projects/yanfs
Could that be used for regression testing?
It was modified 5 years ago and now even is not compiled.
And the bigger question: Would it be worth the trouble?
Source code shouldn't be like a trash dump and shouldn't contain things
that now are not used anymore.
Instead of keeping hundreds of "useful" useless stuff, really useful
thing is concentrate on making code more clear, faster and developing
new features.
For instance, another dead code - NFS code also contains some
volatile-FH stuff that can not be activated from userspace.
Are any other NFS server implementations supporting WebNFS?
I haven't heard about it. Linux doesn't support it.
One main thing - I don't have anything against WebNFS (YaNFS). I really
think that this protocol had to be used instead of original NFSv3.
How much does WebNFS support affect the NFS server code?
Non a lot of, but any changes in v2,v3 code can possible break it. Who
will care?
I gather it causes the appearance of NULL file handles in lookup,
Yes, instead of getting filehandle via MNT protocol it just puts zero
dir at LOOKUP for NFSv3 protocol.
and special behavior for those cases. Anything else?
How much code/work is saved if you eliminate those?
The problem is not in saving code and is not in modification for that.
Problem for all cases is in:
1. That some feature is not used.
2. New code can break it and nobody will notify that it doesn't work.
3. Code becomes complex but nobody gives guarantee that it at least
work.
4. Nobody can explain what is this code for. So some vain code might
not be just improved.
5. During cleanups/modification - all reviews will ask "what about
this NNN code ? Will it work after your patch?".
So patch-writer should spend time and think about dead technology
instead of concentrate of real worked rest of code.
6. Code becomes complex and complex. No optimization, Copy-paste ...
So I would raise this topic to think about all part of code.
---
Vitaliy Gusev
-------------------------------------------
illumos-discuss
Archives: https://www.listbox.com/member/archive/182180/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182180/21175430-2e6923be
Modify Your Subscription:
https://www.listbox.com/member/?member_id=21175430&id_secret=21175430-6a77cda4
Powered by Listbox: http://www.listbox.com
