On 9/12/16 6:23 AM, Alexander Pyhalov wrote: > > This makes me wonder, why we check for adt_* return codes, but don't > return from function at > https://github.com/illumos/openssh-portable/blob/illumos-7.2p2/audit-solaris.c#L179 > and in similar places. >
Yeah that's bad. We should fix that. Do you want to do up a revised version of the patch or shall I? I think when I initially read this patch while including it from the Oracle stack I thought the error() calls were fatal() (which exits after printing). Bit of an oversight. ------------------------------------------- illumos-discuss Archives: https://www.listbox.com/member/archive/182180/=now RSS Feed: https://www.listbox.com/member/archive/rss/182180/21175430-2e6923be Modify Your Subscription: https://www.listbox.com/member/?member_id=21175430&id_secret=21175430-6a77cda4 Powered by Listbox: http://www.listbox.com