Michael, so if I understand correctly, projects that are already using checkstyle with error setting, do not have to switch to odlparent 3.0.0 until they are ready? Or is there some point at which the projects much upgrade to 3.0.0 and be forced to make the checkstyle changes? I recall the effort in the last cycle to constantly bump along the 2.x versions and it seemed a mess as all projects had to make the bumps.
Thanks, Sam On Wed, Sep 20, 2017 at 6:19 AM, Michael Vorburger <[email protected]> wrote: > On Wed, Sep 20, 2017 at 11:56 AM, Lori Jakab <[email protected]> > wrote: > >> Hi Michael, >> >> Thanks for the notification. >> >> Unless it is as simple as switching odlparent version to 3.0.0-SNAPSHOT >> (which may have side effects independent of the checkstyle changes), I >> think it would be useful to also post a quick guide on how to test if the >> new rules (and new checkstyle version 8.2) cause violations on existing >> code, >> > > I guess it's either switching your project to odlparent version to > 3.0.0-SNAPSHOT locally to try it out, or cutting your own local odlparent > branch off 2.x locally and locally cherry-pick from master what > changes-to-come you want to try out.... > > >> so projects can work on those in advance, before bumping to odlparent >> 3.0.0 becomes urgent. >> > > In an ideal world, when released, it should be more of a gradual opt-in, > not an urgent fire broken universe "everyone switch NOW" kind of situation. > (I'm however not entirely sure if that is really how it's going to be.) > > >> >> Thanks, >> -Lori >> >> On Wed, Sep 20, 2017 at 12:46 PM, Michael Vorburger <[email protected] >> > wrote: >> >>> Hello discuss and release list readers (cc odlparent-dev), >>> >>> During the Kernel Projects Call ([1]) yesterday, prompted by a recent >>> discussion on [2] the odlparent-dev list, we've agreed to notify discuss >>> and release lists of upcoming Checkstyle rule changes in future (major) >>> odlparent versions so: >>> >>> Please be informed that for odlparent 3.0.0 we have, so far: >>> >>> * http://checkstyle.sourceforge.net/config_design.html#FinalClass and >>> http://checkstyle.sourceforge.net/config_design.html#HideUti >>> lityClassConstructor (via https://git.opendaylight.org/g >>> errit/#/c/43324/) >>> >>> * http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs >>> /com/github/sevntu/checkstyle/checks/coding/AvoidHidingCause >>> ExceptionCheck.html (via https://git.opendaylight.org/gerrit/#/c/62145/) >>> >>> * but NOT :-( http://sevntu-checkstyle.githu >>> b.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/ >>> checks/coding/EitherLogOrThrowCheck.html as >>> https://git.opendaylight.org/gerrit/#/c/43331/ was abandoned >>> >>> * MAYBE (probably) CS for all *.* src/main/resources and not just >>> *.properties, via https://git.opendaylight.org/gerrit/#/c/48710/ >>> >>> * MAYBE Checkstyle version bump via https://git.opendaylight.org/g >>> errit/#/c/63290/ >>> >>> Should any project enforcing Checkstyle have any major objections to any >>> of these new rules, please shout now. -- Obviously, this only really >>> affects projects having opted to [3] enforce Checkstyle in their builds; >>> those may have to fix some new violations due to above when you'll bump to >>> an odlparent 3.0.0 (not yet released, but planned during Oxygen, AFAIK). >>> For other projects else, this will just be a few additional messages during >>> their builds - which you ignore anyway. >>> >>> Tx, >>> M. >>> >>> [1] https://wiki.opendaylight.org/view/Kernel_Projects_Call >>> >>> [2] https://lists.opendaylight.org/pipermail/odlparent-dev/2017- >>> September/001328.html >>> >>> [3] https://wiki.opendaylight.org/view/BestPractices/Coding_Guid >>> elines#Checkstyle >>> >>> -- >>> Michael Vorburger, Red Hat >>> [email protected] | IRC: vorburger @freenode | ~ = >>> http://vorburger.ch >>> >>> _______________________________________________ >>> Odlparent-dev mailing list >>> [email protected] >>> https://lists.opendaylight.org/mailman/listinfo/odlparent-dev >>> >>> >> > > _______________________________________________ > release mailing list > [email protected] > https://lists.opendaylight.org/mailman/listinfo/release > >
_______________________________________________ Discuss mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/discuss
