Hi,

This e-mail documents the changes I am planing to do to l2switch's arphandler 
to solve the NotificationService warning I have mentioned in my previous two 
e-mails. Specifically for the ProactiveFloodFlowWriter part: floodInvListenerReg

The "ArpHandlerProvider" class is responsible to select the ArpHandler mode 
(reactive/proactive) through its "init" method. Reactive mode has two listener 
registrations, "listenerRegistration" and "topoNodeListenerReg"; while 
proactive mode also has two listener registrations, "floodTopoListenerReg" and 
"floodInvListenerReg".

The "floodInvListenerReg" is registered and implemented through the 
"ProactiveFloodFlowWriter" class as "OpendaylightInventoryListener". However, 
OpendaylightInventoryListener is now a deprecated public interface. This is 
what is causing the warning message!

My proposed solution is to eliminate the "OpendaylightInventoryListener" from 
the "ProactiveFloodFlowWriter" class and to also stop using 
"floodInvListenerReg" listener registration at "ArpHandlerProvider". I believe 
this should not affect the proactive mode because:

1. The "OpendaylightInventoryListener" at the "ProactiveFloodFlowWriter" class 
only has implemented one method, onNodeUpdated, but this method is not used and 
method onDataTreeChanged performs exactly the same tasks. So it seems that the 
latter method is the only one being used.

2. The "floodTopoListenerReg" seems to be the registration used by the 
proactive mode, and "floodInvListenerReg" is currently not being used.

Please, let me know if you see any problems with this plan.

Regards,

David


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#9125): https://lists.opendaylight.org/g/Discuss/message/9125
Mute This Topic: https://lists.opendaylight.org/mt/99883508/21656
Group Owner: discuss+ow...@lists.opendaylight.org
Unsubscribe: https://lists.opendaylight.org/g/Discuss/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to