On Wed, Mar 09, 2005 at 01:09:09PM -0800, kdf wrote:
> any player that connects to http://serverIP:9000/stream.mp3 should be getting
> detected as player type 'http', which is given a 320kbps bitrate limit and
> 'mp3' format only support. clearly, this detection is broken.
Ah I found it. Notice that the command is:
-q $QUALITY$ -b ...
but the actual command is
-q -b 320
So $QUALITY$ is not getting substituted. (Lame is printing out Could not find
"320").
Hence the warning on line 1468 of Source.pm. Good reason to pay
attention to those warnings. There's a default for "lameQuality" in
$defaultPrefs, so not clear why it's not being used.
In Slim::Utils::Prefs.pm:
# get($pref)
sub get {+
return $prefs{$_[0]}+
};
Seems like one would want to test for undefined/exists in the $prefs
hash to at least catch typos. Anyway, seems like lameQuality is not
getting stored in the hash key: 192.168.1.3-lameQuality. It's only
just "lameQuality". Confusion about server vs. client settings, I
suppose. Humm, a single-level config hash.
Anyway, I see initClientPrefs() is not being called for that
client. I wonder why.
$ find -name \*.pm | xargs fgrep initClientPrefs
./Slim/Utils/Prefs.pm:sub initClientPrefs {
./Slim/Player/Player.pm: Slim::Utils::Prefs::initClientPrefs($client,
$defaultPrefs);
./Slim/Player/Squeezebox2.pm:
Slim::Utils::Prefs::initClientPrefs($client,$defaultPrefs);
./Slim/Player/Client.pm:
Slim::Utils::Prefs::initClientPrefs($client,$defaultPrefs);
./Slim/Player/SqueezeboxG.pm:
Slim::Utils::Prefs::initClientPrefs($client,$defaultPrefs);
Oh. Now I'm starting to want to rewrite some code. ;)
2005-03-09 12:43:02.7904 file type: ogg format: mp3 inrate: 128 maxRate: 320
2005-03-09 12:43:02.7906 command: [oggdec] -Q -o - -R $FILE$ | [lame]
--resample 44100 --silent -q $QUALITY$ -b $BITRATE$ -r -x - -
Use of uninitialized value in substitution (s///) at
/home/moseley/SlimServer_v2005-03-08/Slim/Player/Source.pm line 1468.
2005-03-09 12:43:02.7916 Using command for conversion:
"/home/moseley/SlimServer_v2005-03-08/Bin/i386-linux-thread-multi/oggdec" -Q -o
- -R
"/home/moseley/music/Reggae/various_artists/first_family_of_reggae/various_artists
- first_family_of_reggae - 15 - ras_michael__marriage_in_canaan.ogg" |
"/usr/bin/lame" --resample 44100 --silent -q -b 320 -r -x - - & |
2005-03-09 12:43:02.8223 Streaming with format: mp3
Could not find "320".
Error writing to file: Broken pipe
2005-03-09 12:43:02.9051 192.168.1.3 New play mode: play
2005-03-09 12:43:02.9061 192.168.1.3: Current playmode: play
2005-03-09 12:43:02.9070 Generating response for (htm, text/html)
status_header.html
2005-03-09 12:43:02.9073 generating from include.html
Use of uninitialized value in numeric eq (==) at
/home/moseley/SlimServer_v2005-03-08/Slim/Web/Pages.p:m line 961.
Use of uninitialized value in numeric eq (==) at
/home/moseley/SlimServer_v2005-03-08/Slim/Web/Pages.pm line 961.
2005-03-09 12:43:02.9250 generating from status_header.html
2005-03-09 12:43:02.9314 End request: keepAlive: [8] - waiting for next request
on connection = keep-alive
2005-03-09 12:43:02.9329 No more messages to send to 192.168.1.3
2005-03-09 12:43:02.9337 sendstreaming response begun...
2005-03-09 12:43:02.9348 We need to send 0 seconds of silence...
2005-03-09 12:43:02.9352 sending 0 bytes of silence
2005-03-09 12:43:02.9359 Read to end of file or pipe
>
> otherwise, the server uses the reponse from a slimproto query. Odd, still,
> that
> yoru player could stil be detected as sb2 if clearly xmms can't possible have
> responded with a deviceid.
>
> -kdf
>
> -kdf
> _______________________________________________
> Discuss mailing list
> [email protected]
> http://lists.slimdevices.com/lists/listinfo/discuss
>
--
Bill Moseley
[EMAIL PROTECTED]
_______________________________________________
Discuss mailing list
[email protected]
http://lists.slimdevices.com/lists/listinfo/discuss
