MelonMonkey;208535 Wrote: > Too much talk. > > The current implementation, when it works, is fine.
You're right, thanks for the concise approach. :) Something to think about... We're essentially talking about three different aspects of the implementation. They are: 1. Classification of an album as either a compilation or non-compilation. 2. Determining, for presentation (and search?) purposes who the album is "by". In my opinion, this should be independant of any user preferences. It's based solely on whether the album is recognized as a compilation and the contributor/album roles. 3. Sorting, grouping and suppression of artist and/or albums in relation to the current user preferences. > The following assumes the same ALBUM title for all tracks, so we're not > discussing Slim's ability to identify that the tracks belong together > in one volume. Right, that's a separate subject, maybe for another thread. > 1. COMPILATION tag set to YES (rest of tags make no difference) = album > is a compilation I'm fine with that. > 2. No Compilation tag (null), all tracks exactly the same artist = NOT > compilation Correct. Probably the most common case. > 3. Compilation set to NO (rest of tags make no difference) = album is > NOT a compilation This is fine, but it only addresses the album's compilation status. When the ARTISTs on tracks are different, there's still the issue of determining who we say the album is by. When an ALBUMARTIST is specified (which is your #5), we can use the ALBUMARTIST. Without one, then the album artist becomes the combined list of every artist on the album. It could be just one, or it could be many. If someone claims that they don't want to see a bunch of artists listed for the album, then tell them they've either mistakenly set COMPILATION to NO or else they need to specify an ALBUMARTIST. > 4. No Compilation tag (null), all or some tracks different artist = > album is a compilation Correct. You might add that this only when no ALBUMARTIST is specified. With an ALBUMARTIST, it becomes #5. > 5. No compilation tag (null) or compilation set to NO *AND* ALBUMARTIST > specified and identical for all tracks = album NOT a compilation and is > listed under the ALBUMARTIST Correct. > 6. Compilation tag set to YES *AND* ALBUMARTIST specified and identical > for all tracks = album is a compilation and should likely be listed > under ALBUM ARTIST. The track artist listing rule comes from the > current compilation prefs. This is good. I think that's the correct approach - the album should be listed under the album artist when viewing an album list sorted by artist. With cases #3 and #5 (non-compilation albums) we have the issue of what to do with individual track artists. See 'bug 5108' (http://bugs.slimdevices.com/show_bug.cgi?id=5108). The 'group compilations' pref in the current implementation only applies to the artists found on compilations. So if you have a track-only artist on one of these albums that you've marked COMPLIATION=NO, you'd most likely want these artists excluded from the arists list. > Personally I don't mind if it's mandatory to specify the compilation tag > for compilation albums, but I understand a lot of people rely on some > server-side guessing to make this conclusion currently, so I wouldn't > recommend breaking this if it's already in place. Yeah, a mandatory tagging requirement would be bad. It would break a lot of libraries and require way too much work for many people who just want to listen to music. As far as the classification of albums as either compilations or non, I think SlimServer may currently follow the above logic. There are some cases where tagging data can conflict, such as if only one track were marked COMPILATION=YES or if not every track on an album has an ALBUMARTIST specified. The behavior in cases like that can go either way and isn't particularly important, IMO, as any album tagged like this should be considered mis-tagged. The use of ALBUMARTIST tag, and the use of prefs for sorting/display purposes is still in need of work, though. -- JJZolx Jim ------------------------------------------------------------------------ JJZolx's Profile: http://forums.slimdevices.com/member.php?userid=10 View this thread: http://forums.slimdevices.com/showthread.php?t=36062 _______________________________________________ discuss mailing list [email protected] http://lists.slimdevices.com/lists/listinfo/discuss
