mmillot;227370 Wrote: > > (a) I don't understand what $basename% is supposed to do. It's going > to resolve to something like "c:\My Music\Artist1\Album1 (CD1)%". I'm > not sure when that's going to match anything.
It will resolve to the directory, but it will be in url format so it will start with file:// and then the path. I think this code is executed per track, so the basename part will make sure you can have two albums with the exact same name stored in different directories. As I understands it the basename part will only match the album that resides in the same directory as the currently handled file. mmillot;227370 Wrote: > (b) I don't understand why contributor isn't used (whether disc and > discc are defined or not). It seems reasonable to have the same album > title for different artists. Those should be considered different > albums. Using contributors in some way seems like a good idea, the problem though is that a track can have several contributors. In this case the contributor ending up in the albums table which would match me.contributor seems a bit random to me. The information is probably available in the tags if you have tagged your music with a single ALBUMARTIST tag, but if you haven't it got to choose one of the ARTIST tags. So this makes me think that your patch might not work as it should in all cases. One reason that this code tends to get a bit complicated is that there are so many ways you can tag your music. Some people doesn't tag their music at all, some only use ARTIST tags, some use both ALBUMARTIST, ARTIST and TRACKARTIST, there are different file format with different types of tags. I think the current solution with one album per directory works good in most cases, it's just a pitty that it doesn't match the default way iTunes arranges it's music. So if this logic should be changed to something else it really needs to be tested a lot. Have you verified that the patch works as you like in your own library ? -- erland Erland Isaksson 'My homepage' (http://erland.homeip.net) 'My download page' (http://erland.homeip.net/download) (Developer of 'TrackStat, SQLPlayList, DynamicPlayList, Custom Browse, Custom Scan, Custom Skip, Multi Library and Database Query plugins' (http://wiki.erland.homeip.net/index.php/Category:SlimServer)) ------------------------------------------------------------------------ erland's Profile: http://forums.slimdevices.com/member.php?userid=3124 View this thread: http://forums.slimdevices.com/showthread.php?t=38425 _______________________________________________ discuss mailing list [email protected] http://lists.slimdevices.com/lists/listinfo/discuss
