Hi Peter,
My apologies, you're right, I was imprecise - I believe we should only
include primary files in PRs, *not* generated files, so that everyone
who's reviewing has exactly one place to look for changes. (We've seen
some people adding comments on the Markdown, some on the generated HTML,
and some on both.) Does anyone (Raniere?) feel strongly otherwise?
We'll go with majority here...
Thanks,
Greg
On 2015-02-05 1:20 PM, Peter Cock wrote:
Hi Greg,
You said yes (i.e. option one?), but then seemed to describe option two.
I'm confused now about what the best practise is.
Peter
On Thu, Feb 5, 2015 at 6:02 PM, Greg Wilson
<gvwil...@software-carpentry.org> wrote:
Yes - please update the primary source (Markdown, R Markdown, IPython
notebook) in the PR, and we'll re-generate all the secondary files
(generated HTML) when the PR is merged. We should add a note about this
somewhere - where would be the most noticeable place?
Thanks,
Greg
On 2015-02-05 12:51 PM, Peter Cock wrote:
I have been doing (1) when sending in a pull request,
based on my understanding of the README file at the
time - and have seen that requested on the mailing list
too, e.g.:
http://lists.software-carpentry.org/pipermail/discuss_lists.software-carpentry.org/2014-December/002489.html
Peter
On Thu, Feb 5, 2015 at 4:08 PM, Christina Koch <cko...@wisc.edu> wrote:
Hi all,
My apologies if this has already been answered, but I didn't see any
likely
past discussion threads or info on lesson-template: how will the html for
lessons be updated? I see the following options:
1) the pull request should include changed .md source file and
appropriately
re-generated .html
2) the pull request only contains changes in .md and maintainers update
.html a) at time of PR merge or b) once a [insert time interval here].
What have people been doing?
Cheers,
Christina
--
Christina Koch - Research Computing Facilitator,
University of Wisconsin Madison, Center for High Throughput Computing
Advanced Computing Initiative, Wisconsin Institute for Discovery, ACI-REF
_______________________________________________
Discuss mailing list
Discuss@lists.software-carpentry.org
http://lists.software-carpentry.org/mailman/listinfo/discuss_lists.software-carpentry.org
_______________________________________________
Discuss mailing list
Discuss@lists.software-carpentry.org
http://lists.software-carpentry.org/mailman/listinfo/discuss_lists.software-carpentry.org
--
Dr. Greg Wilson | gvwil...@software-carpentry.org
Software Carpentry | http://software-carpentry.org
_______________________________________________
Discuss mailing list
Discuss@lists.software-carpentry.org
http://lists.software-carpentry.org/mailman/listinfo/discuss_lists.software-carpentry.org
--
Dr. Greg Wilson | gvwil...@software-carpentry.org
Software Carpentry | http://software-carpentry.org
_______________________________________________
Discuss mailing list
Discuss@lists.software-carpentry.org
http://lists.software-carpentry.org/mailman/listinfo/discuss_lists.software-carpentry.org
