Frank Meies wrote:
Hi Stephan,
On 01/25/07 13:13, Stephan Bergmann wrote:
<http://blogs.sun.com/GullFOSS/entry/successful_community_project_smart_tags>
made me aware of new UNOIDL content at offapi/com/sun/star/smarttags
(at least available in SRC680m200). Some notes:
- XSmartTagAction.idl:1.2 contains both interface XSmartTagAction and
service SmartTagAction, similar for XSmartTagRecognizer.idl:1.2. I
think it is better to only have one entity definition per .idl file
(named after the entity).
- XSmartTagRecognizer.Recognize is capitalized, which is odd.
- Both XSmartTagAction and XSmartTagRecognizer have a method
initialize, apparently following the semantics of
com.sun.star.lang.XIntialization. Why not just inherit that
interface? Or, if applicable, use service constructors for
initialization (and hiding XInitialization from UNOIDL as an
implementation detail).
- Both SmartTagAction and SmartTagRecognizer are old style services.
Are they needed at all? How are instances of
XSmartTagAction/Recognizer found/instantiated at runtime?
thank you for your comments. These new interfaces/services are community
contributions and still work in progress, they will be reviewed,
discussed and changed accordingly soon.
That makes no difference. I assume that somebody has mentored the
community member and we should follow our own guidelines for new types
always. Why starting with old style type definitions which have to be
changed later anyway.
I totally agree to Stefan and we should fix this asap.
At this point i would like to remember that we won't use old style type
definitions for new types. That it includes no inheritance from
XInterface (obsolete), use multiple inheritance interfaces instead of
old style services. And use new style services when you want to
instantiate your services globally.
If it is unclear how to design new types feel free to ask.
Juergen
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
