On Jul 17, 2011, at 9:29 PM, Ben Pfaff wrote: > On Sun, Jul 17, 2011 at 12:48:42AM -0700, Justin Pettit wrote: >> That said, looking at the source code for replace-flows, it appears >> that it's doing an OFPFC_ADD which should be resetting the counters >> for existing entries. [...] > > I don't think that replace-flows does anything for existing flows that > don't need to change. We could have some version of it that always adds > every flow, or Jed could just delete all the flows and then add them > back.
I had assumed that he was changing something in the flows, since the man page states that flows are only updated if that is the case. However, you may be right. In any case, as I mentioned internally, there is a bug where flows that are active in the kernel aren't properly accounted to changing OpenFlow flows, which could show similar behavior to what Jed described (assuming the flows to be replaced are changing). Ben plans to look into this and write some new unit tests, since counters are an area that's easy to introduce subtle bugs. Thanks, Ben! --Justin _______________________________________________ discuss mailing list [email protected] http://openvswitch.org/mailman/listinfo/discuss
