hi, another confusion about the design is: if facet actually does exact match the same as subfacet in the implementation, the facet_lookup then seems redundant since the flow is already a miss at datapath/subfacet. One possibility is only part of subfacet is inserted into datapath. Do I understand correctly?
Thanks. Feixiong On Thu, Jul 11, 2013 at 1:05 PM, Feixiong Zhang <[email protected] > wrote: > Hi, Justin, > > thanks for your reply. > > I'm looking at code from > http://openvswitch.org/releases/openvswitch-1.9.0.tar.gz. So the code on > facet has changed to comply with wildcard in the newest branch? Which > branch do you recommend to use? I see that 1.9.0 is long term supported > release. > > Thanks. > Feixiong > > > On Thu, Jul 11, 2013 at 11:58 AM, Justin Pettit <[email protected]>wrote: > >> Your description sounds correct for megaflows (branch-1.11 and master), >> but your code walk-through sounds like it was for an older branch. >> >> --Justin >> >> >> On Jul 11, 2013, at 7:36 AM, Feixiong Zhang <[email protected]> >> wrote: >> >> > hello, everyone, >> > >> > I'm looking at the implementation of openvswitch and is confused about >> facet and subfacet. From previous posts, facet represents user space flow >> with wildcard, while subfacet stands for kernel space flow concept with no >> wildcard. Thus a facet consists of multiple subfacets. >> > >> > However, in the implementation, >> > facet_create(rule, &miss->flow, hash) in handle_flow_miss() will create >> a facet with miss->flow as the key. But miss->flow is from kernel datapath >> and doesn't contain wildcard. >> > Moreover, facet_find() uses flow_equal(flow, &facet->flow) to determine >> whether a facet match the flow, and flow_equal() will check all the field >> in the struct flow. And facet_find() is almost the same as >> subfacet_find__(), both uses flow_equal(). >> > It seems in the implementation, facet also relies on exact match of all >> fields, same as subfacet. >> > >> > I'm not sure whether I understand correctly. Can anyone clarify on >> this? Thanks a lot! >> > >> > Regards. >> > Feixiong >> > _______________________________________________ >> > discuss mailing list >> > [email protected] >> > http://openvswitch.org/mailman/listinfo/discuss >> >> >
_______________________________________________ discuss mailing list [email protected] http://openvswitch.org/mailman/listinfo/discuss
