On Thu, Sep 12, 2013 at 01:12:32PM +0200, Torbjorn Tornkvist wrote:
> It seems that ovs 1.11, when talking OpenFlow 1.2 sends wrong number
> of bits set in the match bitmap of the ofp_table_stats match field.
> (see: "A.3.5.4 Table Statistics" in the 1.2 spec)
>
> The (uint64) match field I receive from the bridge looks like (list
> of bytes in decimal):
>
> [0,0,0,255,255,255,255,255]
>
> Which actually seem to correspond to the enum's found in:
> include/openflow/openflow-1.2.h
> as the snippet below shows:
>
> /* OXM Flow match field types for OpenFlow basic class. */
> enum oxm12_ofb_match_fields {
> OFPXMT12_OFB_IN_PORT, /* Switch input port. */
> ....
> OFPXMT12_OFB_MPLS_TC, /* MPLS TC. */
> /* Following added in OpenFlow 1.3 */
> OFPXMT12_OFB_MPLS_BOS, /* MPLS BoS bit. */
> OFPXMT12_OFB_PBB_ISID, /* PBB I-SID. */
> OFPXMT12_OFB_TUNNEL_ID, /* Logical Port Metadata */
> OFPXMT12_OFB_IPV6_EXTHDR, /* IPv6 Extension Header pseudo-field */
>
> /* End Marker */
> OFPXMT12_OFB_MAX,
> };
>
> So why is the extra 1.3 bits included among the 1.2 enum's? A bug?
Looks like a bug. I sent out a fix, CCing you. Please feel free to
review it.
> And also, what seem to be sent on the wire are all those enum's
> representing a bit,
> including the 'End Marker'!?
I don't think the end marker was actually included.
_______________________________________________
discuss mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/discuss
