Sure, so I have to change TYPE=OVSGre to TYPE=OVSTunnel, OVS_GRE_OPTIONS to
OVS_TUNNEL_OPTIONS and may be add a OVS_TUNNEL_TYPE to have something like:
ovs-vsctl -t ${TIMEOUT} -- --may-exist add-port "$OVS_BRIDGE" "$DEVICE"
$OVS_OPTIONS -- set Interface "$DEVICE" type=$OVS_TUNNEL_TYPE
$OVS_TUNNEL_OPTIONS ${OVS_EXTRA+-- $OVS_EXTRA}

is that correct?


2013/10/11 Ben Pfaff <b...@nicira.com>

> On Thu, Oct 10, 2013 at 03:32:54PM -0700, Gurucharan Shetty wrote:
> > On Thu, Oct 10, 2013 at 3:26 PM, Ben Pfaff <b...@nicira.com> wrote:
> > > On Thu, Oct 10, 2013 at 03:20:52PM -0700, Gurucharan Shetty wrote:
> > >> On Thu, Oct 10, 2013 at 3:14 PM, Ben Pfaff <b...@nicira.com> wrote:
> > >> > On Thu, Oct 10, 2013 at 07:59:50PM +0200, Madko wrote:
> > >> >> If someone is interested here are 2 trivial patches to add ifcfg
> > >> >> ifup/ifdown ovs scripts to support gre interface
> > >> >
> > >> > Seems reasonable enough, can I get a Signed-off-by?
> > >>
> > >> If we do this for GRE, then we should do it for other tunnels too.?
> > >
> > > Good point.
> > >
> > >> FYI,
> > >> We can create GRE tunnels through the OVS_EXTRA option when
> > >> TYPE=OVSIntPort with the current mechanism.
> > >
> > > I see that you're right, but that's a counterintuitive way to do it
> > > because one would have to override the type=internal automatically
> > > provided by OVSIntPort.
> > >
> > > What if we added an OVSCustom or OVSTunnel type where one is expected
> to
> > > provide everything?
> > OVSTunnel seems reasonable. Or if you see more cases for OVSCustom,
> > then that is fine too.
>
> I'm OK with OVSTunnel.
>
> Madko, do you want to rewrite your patch to do this?
>



-- 
Edouard Bourguignon
_______________________________________________
discuss mailing list
discuss@openvswitch.org
http://openvswitch.org/mailman/listinfo/discuss

Reply via email to