Hi everyone,
Having read the porting document, and after deciding to implement "ofproto
provider" for my HW
I started working on modifying the following 2 flows: "add flow" and "flow
dump"
1. As for "flow dump" , I was happy to find out that I had just what I
wanted:
Inside handle_flow_stats_request there's the following call:
fproto->ofproto_class->rule_get_stats where I can hook to my HW and collect
some statistics
2. As for "flow add" , I'd like to perform validations:
By validations I mean that I'd like to make sure that the rule doesn't relate
to physical ports I don't actually have
or to preserved vlans (I have a few vlans which I don't want the remote
controller to configure)
or anything else which is in contradiction to the integrity of the HW
besides, there might be layers/protocols that I'm not going to support
(hypothetically, for the sake of argument,let's say that I'm not going to
support MPLS)
I would have wanted to find something like this in the code:
ofproto->ofproto_class->validate() , right at the beginning of the function,
before a new rule is allocated
However, the only function pointers I found are:
ofproto->ofproto_class->rule_choose_table(...)
fproto->ofproto_class->rule_alloc();
ofproto->ofproto_class->rule_construct()
ofproto->ofproto_class->rule_insert(rule);
ule->ofproto->ofproto_class->rule_modify_actions(...)
Now, is my basic assumption that I should hook up to your code only by the
function pointers that you offer correct?
or is it OK to add function calls inside "flow add" as I please?
(hooking to your function pointers only, seems best for me in the sense that I
would have to make no changes once you
make a new release).
Do you have intensions to add something like ofproto->ofproto_class->validate()
in the future?
Do you have other ideas for me?
Thanks
Eyal
This email message and any attachments are intended solely for the use of the
addressees hereof.
This message and any attachments may contain information that is confidential,
privileged and exempt from disclosure under applicable law.
If you are not the intended recipient of this message, you are prohibited from
reading, disclosing, reproducing, distributing, disseminating or otherwise
using this transmission.
If you have received this message in error, please promptly notify the sender
at Ceragon by reply E-mail and immediately delete this message from your system.
_______________________________________________
discuss mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/discuss
