> I suspect that "resubmit" should happen at the end, either before or
> after "group" or "output" actions.
Since "resubmit" will provide another opportunity to add output action
to the action-set, I would vote for having "resubmit" happen at the
end of the action-set, rather than before.
I did a bit more code digging and noticed that the resubmit in group
is not really disallowed. But, rather not taken seriously. Here is a
patch that will fix that issue. I tested the resubmit action within
the group with that patch, and it works! Can I submit this for
upstream?
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index ed30ec2..2ecca2a 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -4481,7 +4481,8 @@ ofpacts_execute_action_set(struct ofpbuf *action_list,
* all the actions because there's no point in modifying a packet that will
* not be sent anywhere. */
if (!ofpacts_copy_last(action_list, action_set, OFPACT_GROUP) &&
- !ofpacts_copy_last(action_list, action_set, OFPACT_OUTPUT)) {
+ !ofpacts_copy_last(action_list, action_set, OFPACT_OUTPUT) &&
+ !ofpacts_copy_last(action_list, action_set, OFPACT_RESUBMIT)) {
ofpbuf_clear(action_list);
}
}
On a related note, Jean Tourrilhes left a coment on the EXT-408 saying
thta giving group actions more power is being worked on for OF1.5.
_______________________________________________
discuss mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/discuss
