Here is the patch I was expecting from the authors of ofproto.c: I made the
changes and here's my patch:
--- ofproto.c.orig 2015-01-31 00:53:58.961069421 -0800
+++ ofproto.c 2015-02-02 23:36:32.176345873 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014 Nicira, Inc.
+ * Copyright (c) 2009-2015 Nicira, Inc.
* Copyright (c) 2010 Jean Tourrilhes - HP-Labs.
*
* Licensed under the Apache License, Version 2.0 (the "License");
@@ -3087,6 +3087,9 @@
ots[i].max_entries = htonl(1000000); /* An arbitrary big number. */
fat_rwlock_rdlock(&p->tables[i].cls.rwlock);
ots[i].active_count = htonl(classifier_count(&p->tables[i].cls));
+ if (i == 0) {
+ ots[i].active_count -= connmgr_count_hidden_rules(p->connmgr);
+ }
fat_rwlock_unlock(&p->tables[i].cls.rwlock);
}
I guess it would be too much to ask for a code review?
On Mon, Feb 2, 2015 at 11:19 PM, Ashok Chippa <[email protected]> wrote:
> Can someone please help?... I AM BLOCKED ON THIS... One hunk has failed
> and I shared that with you. The code base I have (2.3.0) seems to have
> changed significantly where I cannot find a place to add these 4 lines:
>
> + if (i == 0) {
> + s->active_count -= connmgr_count_hidden_rules(
> + ofproto->connmgr);
> + }
>
> This is your code I assume, and it should not take you any time to provide
> a patch that works... I am underwhelmed by your responses... This is not my
> code base and I do not have the luxury to go deep into ofproto.c and track
> all your changes and how the code morphed and then figure out where (and
> how) to add the above 4 lines....
>
> The only place in 2.3.0 that references s->active_count is in
> handle_table_stats_request() function...:
>
> handle_table_stats_request(...)
> {
> ots[i].active_count = htonl(classifier_count(&p->tables[i].cls));
> ...
> }
>
> I am sure this is where it goes...
>
> p.s.: It does not seem like you guys are interested in fixing your bugs...
> I have volunteered to test it. Yet, I am not getting any help. If you think
> it is that easy to fix somone else's code, would you like to try patching
> newer version of my code with an older version of my patch? Let's see how
> easy it is for you guys to find and resolve it...
>
_______________________________________________
discuss mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/discuss
