Hi Daniele, I have incorporated all the comments and created a new pull request as below, https://github.com/openvswitch/openvswitch.github.io/pull/24
Can you please have a look on this new request and let me know your comments if any. Regards _Sugesh From: ddiproietto [mailto:[email protected]] Sent: Thursday, October 22, 2015 9:44 PM To: openvswitch/openvswitch.github.io Cc: Chandran, Sugesh Subject: Re: [openvswitch.github.io] Detailed documentation for configuring native userspace-tunneling in OVS. (#23) Thanks for doing this! This appears to add the guide to the website, but the page doesn't match the style of the rest of the site (it is rendered as simple text). These commits (e7f7d78<https://github.com/openvswitch/openvswitch.github.io/commit/e7f7d78cb558499b4fdd1359da97b8be0019772a> and a8e6f64<https://github.com/openvswitch/openvswitch.github.io/commit/a8e6f6491cc4e6d928a010a8946926213b68942e>) should make more clear how to add an entry to the website. Some comments: * I would rename support/config-cookbooks/userspace-tunneling/README-native-tunneling-DPDK.md to support/config-cookbooks/userspace-tunneling/index.md * The page needs to have an header to be rendered correctly. Something like: --- layout: page status: publish published: true title: Openvswitch Native tunneling configuration guide author: sugchand date: 2015-10-22 categories: - Uncategorized tags: [] comments: [] --- * A link to the page should be placed in the navbar, by editing _data/nav.yml * The markdown is not rendered correctly (the commands are in bold instead of monospace, the ordered list items are not numbered properly). Github has a good cheatsheet that explains their markdown syntax https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet * I would remove sudo from the commands. The other configuration cookbooks do not have it. _BUILD<../blob/master/_BUILD> explains how to test your modifications. Would you mind fixing it and submitting another pull request? Again, thank you for this contribution! — Reply to this email directly or view it on GitHub<https://github.com/openvswitch/openvswitch.github.io/pull/23#issuecomment-150350920>.
_______________________________________________ discuss mailing list [email protected] http://openvswitch.org/mailman/listinfo/discuss
